Skip to content

Static pages#9

Merged
alexmerlin merged 10 commits into
developfrom
stefan-dev
Jul 13, 2026
Merged

Static pages#9
alexmerlin merged 10 commits into
developfrom
stefan-dev

Conversation

@OStefan2001

Copy link
Copy Markdown
Collaborator

Static pages and generic route

Comment thread src/App/templates/layout/default.html.twig Outdated
Comment thread src/App/templates/layout/default.html.twig Outdated
Comment thread src/App/templates/partial/left-menu.html.twig Outdated
Comment thread src/Blog/src/Handler/GetStaticPageDataHandler.php Outdated
Comment thread src/Blog/src/Handler/GetStaticPageDataHandler.php Outdated
Comment thread src/Blog/src/RoutesDelegator.php Outdated
@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 14.00000% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.21%. Comparing base (4c7648f) to head (05be1f8).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...rc/Blog/src/Handler/GetCategoryResourceHandler.php 0.00% 18 Missing ⚠️
src/Blog/src/Repository/PostRepository.php 0.00% 9 Missing ⚠️
src/Blog/src/Handler/GetPostResourceHandler.php 0.00% 7 Missing ⚠️
src/Page/src/Factory/GetPageViewHandlerFactory.php 0.00% 4 Missing ⚠️
src/App/src/Factory/GetIndexViewHandlerFactory.php 0.00% 3 Missing ⚠️
src/App/src/Handler/GetIndexViewHandler.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop       #9      +/-   ##
=============================================
- Coverage      23.32%   23.21%   -0.11%     
- Complexity       174      177       +3     
=============================================
  Files             43       43              
  Lines            759      784      +25     
=============================================
+ Hits             177      182       +5     
- Misses           582      602      +20     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexmerlin alexmerlin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any route that's using these templates:

  • src/Blog/templates/page/contact.html.twig
  • src/Blog/templates/page/dotkernel-packages-oss-lifecycle.html.twig
    I can't find them.

Comment thread src/Blog/src/Handler/GetPostResourceHandler.php Outdated
Comment thread src/Blog/src/Handler/GetCategoryResourceHandler.php Outdated

@alexmerlin alexmerlin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you haven't used it so far, you can run:

  • composer twig-cs-check to validate syntax/formatting in all Twig files
  • composer twig-cs-fix to fix issues in Twig files

Comment thread config/autoload/local.php.dist Outdated
Comment thread config/autoload/local.php.dist Outdated
Comment thread src/App/templates/layout/default.html.twig
Comment thread src/Blog/src/Handler/GetCategoryResourceHandler.php Outdated
Comment thread src/App/templates/layout/default.html.twig
Comment thread src/App/templates/layout/default.html.twig
@OStefan2001 OStefan2001 requested a review from alexmerlin July 13, 2026 15:39
@alexmerlin alexmerlin merged commit 652542b into develop Jul 13, 2026
14 of 16 checks passed
@alexmerlin alexmerlin deleted the stefan-dev branch July 13, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants